user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] searchview: fix mbox.gz downloads for lynx users
@ 2020-08-22  0:41 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-08-22  0:41 UTC (permalink / raw)
  To: meta

Unlike w3m and links, the lynx browser seems to require a `name'
attribute for `<input type=submit>' elements.  Maybe some other
browsers do, too.  The `name' attribute for submit elements
doesn't seem to cause any harm for w3m or links, users, either;
despite not (AFAIK) being part of historical or current HTML
specs.
---
 lib/PublicInbox/SearchView.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index aa8fa037..75e2d39d 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -185,9 +185,11 @@ sub search_nav_top {
 		$rv .= qq{<a\nhref="?$s">summary</a>|<b>nested</b>};
 	}
 	my $A = $q->qs_html(x => 'A', r => undef);
-	$rv .= qq{|<a\nhref="?$A">Atom feed</a>]};
-	$rv .= qq{\n\t\t\t\t\t\tdownload: };
-	$rv .= qq{<input\ntype=submit\nvalue="mbox.gz"/></pre></form><pre>};
+	$rv .= qq{|<a\nhref="?$A">Atom feed</a>]} .
+		qq{\n\t\t\t\t\t\tdownload: } .
+		# lynx seems to require a name=, here, so just use 'z'
+		qq{<input\ntype=submit\nname=z\nvalue="mbox.gz"/>} .
+		q{</pre></form><pre>};
 }
 
 sub search_nav_bot {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-22  0:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22  0:41 [PATCH] searchview: fix mbox.gz downloads for lynx users Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).