From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9A3321F66E for ; Sat, 22 Aug 2020 00:41:25 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] searchview: fix mbox.gz downloads for lynx users Date: Sat, 22 Aug 2020 00:41:25 +0000 Message-Id: <20200822004125.9458-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Unlike w3m and links, the lynx browser seems to require a `name' attribute for `' elements. Maybe some other browsers do, too. The `name' attribute for submit elements doesn't seem to cause any harm for w3m or links, users, either; despite not (AFAIK) being part of historical or current HTML specs. --- lib/PublicInbox/SearchView.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index aa8fa037..75e2d39d 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -185,9 +185,11 @@ sub search_nav_top { $rv .= qq{summary|nested}; } my $A = $q->qs_html(x => 'A', r => undef); - $rv .= qq{|Atom feed]}; - $rv .= qq{\n\t\t\t\t\t\tdownload: }; - $rv .= qq{
};
+	$rv .= qq{|Atom feed]} .
+		qq{\n\t\t\t\t\t\tdownload: } .
+		# lynx seems to require a name=, here, so just use 'z'
+		qq{} .
+		q{
};
 }
 
 sub search_nav_bot {