From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/7] xapcmd: remove redundant searchidx require
Date: Fri, 7 Aug 2020 01:14:01 +0000 [thread overview]
Message-ID: <20200807011406.12285-3-e@yhbt.net> (raw)
In-Reply-To: <20200807011406.12285-1-e@yhbt.net>
We already "use" it starting with commit
cd8dd7b08fddc7c2b5f218c3fcaa5dca5f9ad945
("search: support SWIG-generated Xapian.pm"),
so there's no need to require it redundantly.
---
lib/PublicInbox/Xapcmd.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index 8d09ed27..47a018d2 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -264,7 +264,6 @@ sub run {
$reindex = $opt->{reindex} = { # per-epoch ranges for v2
from => $ibx->version == 1 ? '' : [],
};
- require PublicInbox::SearchIdx;
PublicInbox::SearchIdx::load_xapian_writable();
}
next prev parent reply other threads:[~2020-08-07 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 1:13 [PATCH 0/7] index: --sequential-shard and other stuff Eric Wong
2020-08-07 1:14 ` [PATCH 1/7] xapcmd: quietly no-op on indexlevel=basic Eric Wong
2020-08-07 1:14 ` Eric Wong [this message]
2020-08-07 1:14 ` [PATCH 3/7] xapcmd: drop outdated comment Eric Wong
2020-08-07 1:14 ` [PATCH 4/7] v2writable: fix rethread cleanup Eric Wong
2020-08-07 1:14 ` [PATCH 5/7] index: v2: --sequential-shard option Eric Wong
2020-08-07 1:14 ` [PATCH 6/7] index: support --xapian-only switch Eric Wong
2020-08-07 1:14 ` [PATCH 7/7] index+xcpdb: rename `--no-sync' to `--no-fsync' Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807011406.12285-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
--subject='Re: [PATCH 2/7] xapcmd: remove redundant searchidx require' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).