user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
To: Kyle Meyer <>
Subject: Re: [PATCH] wwwlisting: fix grep call for match=domain filtering
Date: Thu, 30 Jul 2020 08:03:54 +0000	[thread overview]
Message-ID: <20200730080353.GA14766@dcvr> (raw)
In-Reply-To: <>

Kyle Meyer <> wrote:
> The grep call in list_match_domain_i returns true for all inboxes,
> even ones without a URL that matches the regular expression, because
> the qr value passed to grep is not surrounded by slashes.  Add them.
> Fixes: 1988d730c0088e8b (config: support multi-value inbox.*.*url)

Thanks, pushed as commit 41ecd08ee60daa495de3a2fc2c0296dc9cc9a0b3

>  sub list_match_domain_i {
>  	my ($ibx, $arg) = @_;
>  	my ($list, $hide_key, $re) = @$arg;
> -	if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
> +	if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {

Gah, I keep getting languages/behaviors confused :x

Especially confusing since `$string =~ $re' is documented
in perlop(1) as being equivalent to `$string =~ /$re/'

  reply	other threads:[~2020-07-30  8:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  5:30 Kyle Meyer
2020-07-30  8:03 ` Eric Wong [this message]
2020-07-30 14:58   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730080353.GA14766@dcvr \ \ \ \
    --subject='Re: [PATCH] wwwlisting: fix grep call for match=domain filtering' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ \
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone