From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 37C4B1F5AE; Wed, 29 Jul 2020 11:32:25 +0000 (UTC) Date: Wed, 29 Jul 2020 11:32:25 +0000 From: Eric Wong To: meta@public-inbox.org Subject: Re: [PATCH] v2writable: use {inboxdir} for msgmap->tmp_clone Message-ID: <20200729113224.GB7999@dcvr> References: <20200728232554.1762-1-e@yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200728232554.1762-1-e@yhbt.net> List-Id: Eric Wong wrote: > + my ($self, $dir) = @_; > + my ($fh, $fn) = tempfile('msgmap-XXXXXXXX', EXLOCK => 0, DIR => $dir); > my $tmp; > if ($self->{dbh}->can('sqlite_backup_to_dbh')) { > $tmp = ref($self)->new_file($fn, 2); > diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm > index 6908bd2e..6b0bdc73 100644 > --- a/lib/PublicInbox/V2Writable.pm > +++ b/lib/PublicInbox/V2Writable.pm > @@ -1225,7 +1225,7 @@ sub index_sync { > # only for batch performance. > $self->{mm}->{dbh}->rollback; > $self->{mm}->{dbh}->begin_work; > - $sync->{mm_tmp} = $self->{mm}->tmp_clone; > + $sync->{mm_tmp} = $self->{mm}->tmp_clone($self->{inboxdir}); That is wrong, and the `undef' didn't get noticed since tempfile() sees `DIR => undef' and just uses the current working directory. Will squash this in: diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 6b0bdc73..e071bc1e 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -1225,7 +1225,8 @@ sub index_sync { # only for batch performance. $self->{mm}->{dbh}->rollback; $self->{mm}->{dbh}->begin_work; - $sync->{mm_tmp} = $self->{mm}->tmp_clone($self->{inboxdir}); + $sync->{mm_tmp} = + $self->{mm}->tmp_clone($self->{ibx}->{inboxdir}); } if ($sync->{index_max_size} = $self->{ibx}->{index_max_size}) { $sync->{index_oid} = \&index_oid;