[PATCH] overidx: fix compatibility with current versions

[PATCH] overidx: fix compatibility with current versions

[Eric Wong]

We still need to use SQL_BLOB to ensure existing versions
of public-inbox can read over.sqlite3.  This partially
reverts commit e9fc1290ead44e06d20ff58e0a6acb5306d4fbe2.

Fixes: e9fc1290ead44e06 ("over: unset sqlite_unicode attribute")
---
 lib/PublicInbox/OverIdx.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index fcb450794..5821c562b 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -12,7 +12,7 @@ use strict;
 use warnings;
 use base qw(PublicInbox::Over);
 use IO::Handle;
-use DBI;
+use DBI qw(:sql_types); # SQL_BLOB
 use PublicInbox::MID qw/id_compress mids_for_index references/;
 use PublicInbox::Smsg qw(subject_normalized);
 use Compress::Zlib qw(compress);
@@ -337,7 +337,7 @@ VALUES (?,?,?,?,?,?)
 	my $n = 0;
 	my @v = ($num, $tid, $sid, $ts, $ds);
 	foreach (@v) { $sth->bind_param(++$n, $_) }
-	$sth->bind_param(++$n, $ddd);
+	$sth->bind_param(++$n, $ddd, SQL_BLOB);
 	$sth->execute;
 	$sth = $dbh->prepare_cached(<<'');
 INSERT INTO id2num (id, num) VALUES (?,?)

Re: [PATCH] overidx: fix compatibility with current versions

[Eric Wong]

Eric Wong <e@yhbt.net> wrote:
> We still need to use SQL_BLOB to ensure existing versions
> of public-inbox can read over.sqlite3.

... because they're still using {sqlite_unicode}

Will squash that in before pushing.

> This partially
> reverts commit e9fc1290ead44e06d20ff58e0a6acb5306d4fbe2.
> 
> Fixes: e9fc1290ead44e06 ("over: unset sqlite_unicode attribute")