user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] index: --compact respects --jobs.
@ 2020-07-26  9:31 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-07-26  9:31 UTC (permalink / raw)
  To: meta

And -compact supports --jobs=0 like -index to disable parallel
execution.  Running three xapian-compact processes in parallel
on a USB 2.0 HDD is pretty painful.
---
 lib/PublicInbox/Xapcmd.pm | 2 +-
 script/public-inbox-index | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index d6c069d75..3b7a581bd 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -129,7 +129,7 @@ sub same_fs_or_die ($$) {
 
 sub process_queue {
 	my ($queue, $cb, $opt) = @_;
-	my $max = $opt->{jobs} || scalar(@$queue);
+	my $max = $opt->{jobs} // scalar(@$queue);
 	if ($max <= 1) {
 		while (defined(my $args = shift @$queue)) {
 			$cb->($args, $opt);
diff --git a/script/public-inbox-index b/script/public-inbox-index
index d5c7cae2b..5a0ceab78 100755
--- a/script/public-inbox-index
+++ b/script/public-inbox-index
@@ -24,6 +24,9 @@ if ($opt->{compact}) {
 	require PublicInbox::Xapcmd;
 	PublicInbox::Xapcmd::check_compact();
 	$compact_opt = { -coarse_lock => 1, compact => 1 };
+	if (defined(my $jobs = $opt->{jobs})) {
+		$compact_opt->{jobs} = $jobs;
+	}
 }
 
 my $cfg = PublicInbox::Config->new;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-26  9:31 [PATCH] index: --compact respects --jobs Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git