From: Eric Wong <e@yhbt.net> To: meta@public-inbox.org Subject: [PATCH 20/20] v2writable: {unindexed} belongs in $sync state Date: Fri, 24 Jul 2020 05:56:06 +0000 [thread overview] Message-ID: <20200724055606.27332-21-e@yhbt.net> (raw) In-Reply-To: <20200724055606.27332-1-e@yhbt.net> There's no reason for {unindexed} to persist beyond an ->index_sync call. --- lib/PublicInbox/V2Writable.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 9a58a7a94..f159d39c2 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -891,12 +891,12 @@ sub reindex_oid ($$$) { } # {unindexed} is unlikely - if ((my $unindexed = $self->{unindexed}) && scalar(@$mids) == 1) { + if ((my $unindexed = $sync->{unindexed}) && scalar(@$mids) == 1) { $num = delete($unindexed->{$mids->[0]}); if (defined $num) { $mid0 = $mids->[0]; $self->{mm}->mid_set($num, $mid0); - delete($self->{unindexed}) if !keys(%$unindexed); + delete($sync->{unindexed}) if !keys(%$unindexed); } } if (!defined($num)) { # reuse if reindexing (or duplicates) @@ -1125,7 +1125,7 @@ sub unindex_oid ($$;$) { # a mirror because the source used -purge or -edit sub unindex ($$$$) { my ($self, $sync, $git, $unindex_range) = @_; - my $unindexed = $self->{unindexed} ||= {}; # $mid0 => $num + my $unindexed = $sync->{unindexed} ||= {}; # $mid0 => $num my $before = scalar keys %$unindexed; # order does not matter, here: my @cmd = qw(log --raw -r
prev parent reply other threads:[~2020-07-24 5:56 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 5:55 [PATCH 00/20] indexing changes and new features Eric Wong 2020-07-24 5:55 ` [PATCH 01/20] index: support --rethread switch to fix old indices Eric Wong 2020-07-24 5:55 ` [PATCH 02/20] v2: index forwards (via `git log --reverse') Eric Wong 2020-07-24 5:55 ` [PATCH 03/20] v2writable: introduce idx_stack Eric Wong 2020-07-24 5:55 ` [PATCH 04/20] v2writable: index_sync: reduce fill_alternates calls Eric Wong 2020-07-24 5:55 ` [PATCH 05/20] v2writable: move {autime} and {cotime} into $sync state Eric Wong 2020-07-24 5:55 ` [PATCH 06/20] v2writable: allow >= 40 byte git object IDs Eric Wong 2020-07-24 5:55 ` [PATCH 07/20] v2writable: drop "EPOCH.git indexing $RANGE" progress Eric Wong 2020-07-24 5:55 ` [PATCH 08/20] use consistent {ibx} field for writable code paths Eric Wong 2020-07-24 5:55 ` [PATCH 09/20] search: avoid copying {inboxdir} Eric Wong 2020-07-24 5:55 ` [PATCH 10/20] v2writable: use read-only PublicInbox::Git for cat_file Eric Wong 2020-07-24 5:55 ` [PATCH 11/20] v2writable: get rid of {reindex_pipe} field Eric Wong 2020-07-24 5:55 ` [PATCH 12/20] v2writable: clarify "epoch" comment Eric Wong 2020-07-24 5:55 ` [PATCH 13/20] xapcmd: set {from} properly for v1 inboxes Eric Wong 2020-07-24 5:56 ` [PATCH 14/20] searchidx: rename _xdb_{acquire,release} => idx_ Eric Wong 2020-07-24 5:56 ` [PATCH 15/20] searchidx: make v1 indexing closer to v2 Eric Wong 2020-07-24 5:56 ` [PATCH 16/20] index+xcpdb: support --no-sync flag Eric Wong 2020-07-24 5:56 ` [PATCH 17/20] v2writable: share log2stack code with v1 Eric Wong 2020-07-24 5:56 ` [PATCH 18/20] searchidx: support async git check Eric Wong 2020-07-24 5:56 ` [PATCH 19/20] searchidx: $batch_cb => v1_checkpoint Eric Wong 2020-07-24 5:56 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200724055606.27332-21-e@yhbt.net \ --to=e@yhbt.net \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 20/20] v2writable: {unindexed} belongs in $sync state' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).