From: Eric Wong <e@yhbt.net> To: meta@public-inbox.org Subject: [PATCH 2/8] drop binmode usage Date: Fri, 17 Jul 2020 06:31:49 +0000 [thread overview] Message-ID: <20200717063155.3734-3-e@yhbt.net> (raw) In-Reply-To: <20200717063155.3734-1-e@yhbt.net> We only support Unix-like platforms where binmode (":raw") is the default anyways, and v5.10 semantics means it won't do unicode_strings (unlike v5.12). So save some lines of code. --- lib/PublicInbox/Import.pm | 2 -- lib/PublicInbox/SearchIdxShard.pm | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index fb813159..b61d4b31 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -73,8 +73,6 @@ sub gfi_start { $self->{out} = $out_w; $self->{pid} = $pid; $self->{nchg} = 0; - binmode $out_w, ':raw' or die "binmode :raw failed: $!"; - binmode $in_r, ':raw' or die "binmode :raw failed: $!"; ($in_r, $out_w); } diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index baf7352a..b51d148b 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -26,8 +26,6 @@ sub spawn_worker { my ($self, $v2w, $shard) = @_; my ($r, $w); pipe($r, $w) or die "pipe failed: $!\n"; - binmode $r, ':raw'; - binmode $w, ':raw'; $w->autoflush(1); my $pid = fork; defined $pid or die "fork failed: $!\n";
next prev parent reply other threads:[~2020-07-17 6:31 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 6:31 [PATCH 0/8] indexing cleanup and code reduction Eric Wong 2020-07-17 6:31 ` [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings Eric Wong 2020-07-17 6:31 ` Eric Wong [this message] 2020-07-17 6:31 ` [PATCH 3/8] import: use common capitalization for filtering headers Eric Wong 2020-07-17 6:31 ` [PATCH 4/8] with_umask: pass args to callback Eric Wong 2020-07-17 6:31 ` [PATCH 5/8] overidx: each_by_mid: pass self and args to callbacks Eric Wong 2020-07-17 6:31 ` [PATCH 6/8] overidx: favor non-OO sub dispatch for internal subs Eric Wong 2020-07-17 6:31 ` [PATCH 7/8] searchidx: use v5.10.1, parent.pm, drop warnings Eric Wong 2020-07-17 6:31 ` [PATCH 8/8] search: simplify unindexing Eric Wong 2020-07-17 7:25 ` [9/8 PATCH] v2writable: git_hash_raw: avoid $TMPDIR write Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200717063155.3734-3-e@yhbt.net \ --to=e@yhbt.net \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 2/8] drop binmode usage' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).