user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: Re: [PATCH v2] git_async_cat: unref pipes on EOF from git->cleanup
Date: Mon, 6 Jul 2020 19:48:46 +0000	[thread overview]
Message-ID: <20200706194846.GA28969@dcvr> (raw)
In-Reply-To: <20200706061102.GA15566@dcvr>

Will also squash this in because ->requeue could cause us to
reenter event_step after ->close.

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index e79f416d..e618d366 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -25,10 +25,10 @@ sub _add {
 sub event_step {
 	my ($self) = @_;
 	my $git = $self->{git};
-	return $self->close if ($git->{in} // 0) != $self->{sock};
+	return $self->close if ($git->{in} // 0) != ($self->{sock} // 1);
 	my $inflight = $git->{inflight};
 	if ($inflight && @$inflight) {
 		$self->requeue if @$inflight || exists $git->{cat_rbuf};

      reply	other threads:[~2020-07-06 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 22:50 [PATCH] " Eric Wong
2020-07-06  6:11 ` [PATCH v2] " Eric Wong
2020-07-06 19:48   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706194846.GA28969@dcvr \ \ \
    --subject='Re: [PATCH v2] git_async_cat: unref pipes on EOF from git->cleanup' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).