From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0B03E1F5AF for ; Sun, 5 Jul 2020 23:28:00 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 01/43] gzipfilter: minor cleanups Date: Sun, 5 Jul 2020 23:27:17 +0000 Message-Id: <20200705232759.3161-2-e@yhbt.net> In-Reply-To: <20200705232759.3161-1-e@yhbt.net> References: <20200705232759.3161-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We currently don't use bytes::length in ->write, so there's no need to `use bytes'. Favor `//=' to describe the intent of the conditional assignment since the C::R::Z::Deflate object is always truthy. Also use the local $gz variable to avoid unnecessary {gz} hash lookups. --- lib/PublicInbox/GzipFilter.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm index 864095862..a7355a8df 100644 --- a/lib/PublicInbox/GzipFilter.pm +++ b/lib/PublicInbox/GzipFilter.pm @@ -4,7 +4,6 @@ # Qspawn filter package PublicInbox::GzipFilter; use strict; -use bytes (); # length use Compress::Raw::Zlib qw(Z_FINISH Z_OK); my %OPT = (-WindowBits => 15 + 16, -AppendOutput => 1); @@ -24,21 +23,21 @@ sub translate ($$) { # allocate the zlib context lazily here, instead of in ->new. # Deflate contexts are memory-intensive and this object may # be sitting in the Qspawn limiter queue for a while. - my $gz = $self->{gz} ||= do { + my $gz = $self->{gz} //= do { my ($g, $err) = Compress::Raw::Zlib::Deflate->new(%OPT); $err == Z_OK or die "Deflate->new failed: $err"; $g; }; my $zbuf = delete($self->{zbuf}); if (defined $_[1]) { # my $buf = $_[1]; - my $err = $self->{gz}->deflate($_[1], $zbuf); + my $err = $gz->deflate($_[1], $zbuf); die "gzip->deflate: $err" if $err != Z_OK; return $zbuf if length($zbuf) >= 8192; $self->{zbuf} = $zbuf; ''; } else { # undef == EOF - my $err = $self->{gz}->flush($zbuf, Z_FINISH); + my $err = $gz->flush($zbuf, Z_FINISH); die "gzip->flush: $err" if $err != Z_OK; $zbuf; }