From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 53F131F8DB for ; Wed, 1 Jul 2020 21:06:20 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 4/5] tests: add use/require statements for TEST_RUN_MODE=0 Date: Wed, 1 Jul 2020 21:06:18 +0000 Message-Id: <20200701210619.29601-5-e@yhbt.net> In-Reply-To: <20200701210619.29601-1-e@yhbt.net> References: <20200701210619.29601-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The default (and fast) TEST_RUN_MODE=2 preloads most modules, but TEST_RUN_MODE=0 is more realistic and can catch some problems which may show up in real-world use. --- lib/PublicInbox/InboxWritable.pm | 1 + t/init.t | 1 + t/nntpd.t | 1 + 3 files changed, 3 insertions(+) diff --git a/lib/PublicInbox/InboxWritable.pm b/lib/PublicInbox/InboxWritable.pm index 9bdf8637e6e..875dcce20b7 100644 --- a/lib/PublicInbox/InboxWritable.pm +++ b/lib/PublicInbox/InboxWritable.pm @@ -44,6 +44,7 @@ sub init_inbox { PublicInbox::Import::init_bare($dir); if (defined($self->{indexlevel}) || defined($skip_artnum)) { require PublicInbox::SearchIdx; + require PublicInbox::Msgmap; my $sidx = PublicInbox::SearchIdx->new($self, 1); # just create $sidx->begin_txn_lazy; $self->with_umask(sub { diff --git a/t/init.t b/t/init.t index f4ebc2f67e6..5c021be729b 100644 --- a/t/init.t +++ b/t/init.t @@ -53,6 +53,7 @@ sub quiet_fail { SKIP: { require_mods(qw(DBD::SQLite Search::Xapian::WritableDatabase), 2); require_git(2.6, 1) or skip "git 2.6+ required", 2; + use_ok 'PublicInbox::Msgmap'; local $ENV{PI_DIR} = "$tmpdir/.public-inbox/"; my $cfgfile = "$ENV{PI_DIR}/config"; my $cmd = [ '-init', '-V2', 'v2list', "$tmpdir/v2list", diff --git a/t/nntpd.t b/t/nntpd.t index d72d6a1ce7e..28008ec15f7 100644 --- a/t/nntpd.t +++ b/t/nntpd.t @@ -396,6 +396,7 @@ sub test_watch { my ($tmpdir, $sock, $group) = @_; use_ok 'PublicInbox::WatchMaildir'; use_ok 'PublicInbox::InboxIdle'; + use_ok 'PublicInbox::Config'; require_git('1.8.5', 1) or skip('git 1.8.5+ needed for --urlmatch', 4); my $old_env = { HOME => $ENV{HOME} }; my $home = "$tmpdir/watch_home";