user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 4/5] tests: add use/require statements for TEST_RUN_MODE=0
Date: Wed,  1 Jul 2020 21:06:18 +0000	[thread overview]
Message-ID: <20200701210619.29601-5-e@yhbt.net> (raw)
In-Reply-To: <20200701210619.29601-1-e@yhbt.net>

The default (and fast) TEST_RUN_MODE=2 preloads most modules,
but TEST_RUN_MODE=0 is more realistic and can catch some
problems which may show up in real-world use.
---
 lib/PublicInbox/InboxWritable.pm | 1 +
 t/init.t                         | 1 +
 t/nntpd.t                        | 1 +
 3 files changed, 3 insertions(+)

diff --git a/lib/PublicInbox/InboxWritable.pm b/lib/PublicInbox/InboxWritable.pm
index 9bdf8637e6e..875dcce20b7 100644
--- a/lib/PublicInbox/InboxWritable.pm
+++ b/lib/PublicInbox/InboxWritable.pm
@@ -44,6 +44,7 @@ sub init_inbox {
 		PublicInbox::Import::init_bare($dir);
 		if (defined($self->{indexlevel}) || defined($skip_artnum)) {
 			require PublicInbox::SearchIdx;
+			require PublicInbox::Msgmap;
 			my $sidx = PublicInbox::SearchIdx->new($self, 1); # just create
 			$sidx->begin_txn_lazy;
 			$self->with_umask(sub {
diff --git a/t/init.t b/t/init.t
index f4ebc2f67e6..5c021be729b 100644
--- a/t/init.t
+++ b/t/init.t
@@ -53,6 +53,7 @@ sub quiet_fail {
 SKIP: {
 	require_mods(qw(DBD::SQLite Search::Xapian::WritableDatabase), 2);
 	require_git(2.6, 1) or skip "git 2.6+ required", 2;
+	use_ok 'PublicInbox::Msgmap';
 	local $ENV{PI_DIR} = "$tmpdir/.public-inbox/";
 	my $cfgfile = "$ENV{PI_DIR}/config";
 	my $cmd = [ '-init', '-V2', 'v2list', "$tmpdir/v2list",
diff --git a/t/nntpd.t b/t/nntpd.t
index d72d6a1ce7e..28008ec15f7 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -396,6 +396,7 @@ sub test_watch {
 	my ($tmpdir, $sock, $group) = @_;
 	use_ok 'PublicInbox::WatchMaildir';
 	use_ok 'PublicInbox::InboxIdle';
+	use_ok 'PublicInbox::Config';
 	require_git('1.8.5', 1) or skip('git 1.8.5+ needed for --urlmatch', 4);
 	my $old_env = { HOME => $ENV{HOME} };
 	my $home = "$tmpdir/watch_home";

  parent reply	other threads:[~2020-07-01 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 21:06 [PATCH 0/5] some random minor fixes Eric Wong
2020-07-01 21:06 ` [PATCH 1/5] spawn: make @RLIMITS an array Eric Wong
2020-07-01 21:06 ` [PATCH 2/5] spawn: modernize with parent.pm, drop warnings.pm Eric Wong
2020-07-01 21:06 ` [PATCH 3/5] watch: retry signals to kill IDLE and polling processes Eric Wong
2020-07-01 21:06 ` Eric Wong [this message]
2020-07-01 21:06 ` [PATCH 5/5] overidx: document why we don't use SQLite WAL Eric Wong
2020-07-02 20:12 ` [PATCH 6/5] spawn: drop unused sys/uio.h include Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701210619.29601-5-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).