From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 147AB1F5AE for ; Sun, 28 Jun 2020 07:14:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] eml: header_str_set: correctly encode UTF-8 headers Date: Sun, 28 Jun 2020 07:14:40 +0000 Message-Id: <20200628071440.17244-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Apparently, using $1 from an octet string still results in a multi-byte string. Thus we need to perform utf8::encode after the regexp character match to ensure wide characters don't get passed to encode_base64. This fixes a bug in which caused -watch to crash when using PublicInbox::Filter::SubjectTag to remove "[list prefix]" tags from Subject: lines. I only found this bug because the proposed -watch updates for NNTP/IMAP support introduced a possible bug which triggered a full rescan of old archives: https://public-inbox.org/meta/20200627100400.9871-1-e@yhbt.net/ --- lib/PublicInbox/Eml.pm | 7 +++++-- t/filter_subjecttag.t | 10 ++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Eml.pm b/lib/PublicInbox/Eml.pm index ec682b919ea..1fecd41be9f 100644 --- a/lib/PublicInbox/Eml.pm +++ b/lib/PublicInbox/Eml.pm @@ -368,9 +368,12 @@ sub header_str_set { my ($self, $name, @vals) = @_; for (@vals) { next unless /[^\x20-\x7e]/; - utf8::encode($_); # to octets # 39: int((75 - length("Subject: =?UTF-8?B?".'?=') ) / 4) * 3; - s/(.{1,39})/'=?UTF-8?B?'.encode_base64($1, '').'?='/ges; + s/(.{1,39})/ + my $x = $1; + utf8::encode($x); # to octets + '=?UTF-8?B?'.encode_base64($x, '').'?=' + /xges; } header_set($self, $name, @vals); } diff --git a/t/filter_subjecttag.t b/t/filter_subjecttag.t index 75effa2769a..e2d91e7416e 100644 --- a/t/filter_subjecttag.t +++ b/t/filter_subjecttag.t @@ -24,4 +24,14 @@ $mime->header_str_set('Subject', '[FOO] bar'); $mime = $f->delivery($mime); is($mime->header('Subject'), 'bar', 'filtered non-reply'); +$f = PublicInbox::Filter::SubjectTag->new(-tag => '[sox-devel]'); +my $eml = PublicInbox::Eml->new(<delivery($eml); +my $s = $eml->header('Subject'); +utf8::encode($s); # to octets +is($s, "Re: \xc5\xa1", 'subject filtered correctly'); + done_testing();