user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] testcommon: DS->Reset when using fork-only subprocess
@ 2020-06-23 21:17 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-06-23 21:17 UTC (permalink / raw)
  To: meta

This fixes a bug on FreeBSD 11 here -nntpd + TEST_RUN_MODE=2
(default) was occasionally causing failures in t/v2writable.t
due to the kqueue descriptor being auto-closed by the OS on fork.
---
 lib/PublicInbox/TestCommon.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 6bf4526a..dc360135 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -372,6 +372,7 @@ sub start_script {
 		}
 		$0 = join(' ', @$cmd);
 		if ($sub) {
+			eval { PublicInbox::DS->Reset };
 			_run_sub($sub, $key, \@argv);
 			POSIX::_exit($? >> 8);
 		} else {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-23 21:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 21:17 [PATCH] testcommon: DS->Reset when using fork-only subprocess Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).