user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] imap: stop_idle: fix parameter parsing :x
@ 2020-06-15  9:17 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-06-15  9:17 UTC (permalink / raw)
  To: meta

stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects.  This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
 sub stop_idle ($$) {
-	my ($self, $ibx);
+	my ($self, $ibx) = @_;
 	my $sock = $self->{sock} or return;
 	my $fd = fileno($sock);
 	delete $IDLERS->{$fd};

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-15  9:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15  9:17 [PATCH] imap: stop_idle: fix parameter parsing :x Eric Wong

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).