user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH] imap: stop_idle: fix parameter parsing :x
Date: Mon, 15 Jun 2020 09:17:28 +0000	[thread overview]
Message-ID: <> (raw)

stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects.  This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
 sub stop_idle ($$) {
-	my ($self, $ibx);
+	my ($self, $ibx) = @_;
 	my $sock = $self->{sock} or return;
 	my $fd = fileno($sock);
 	delete $IDLERS->{$fd};

                 reply	other threads:[~2020-06-15  9:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).