user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] t/imapd: quiet overload warning from Mail::IMAPClient
Date: Sat, 13 Jun 2020 20:27:04 +0000	[thread overview]
Message-ID: <20200613202704.25602-1-e@yhbt.net> (raw)

Mail::IMAPClient understandably stumbles into a warning
by our bogus test request.  Just silence it on our end
since it's not normal operation for Mail::IMAPClient.
---
 t/imapd.t | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/t/imapd.t b/t/imapd.t
index f5ca8b7e..56dd80a7 100644
--- a/t/imapd.t
+++ b/t/imapd.t
@@ -147,10 +147,16 @@ is_deeply(scalar $mic->flags('1'), [], '->flags works');
 	my $exp = $mic->fetch_hash(1, 'UID');
 	$ret = $mic->fetch_hash('559:*', 'UID');
 	is_deeply($ret, $exp, 'beginning range too big');
-	for my $r (qw(559:558 558:559)) {
-		$ret = $mic->fetch_hash($r, 'UID');
+	{
+		my @w; # Mail::IMAPClient hits a warning via overload
+		local $SIG{__WARN__} = sub { push @w, @_ };
+		$ret = $mic->fetch_hash(my $r = '559:558', 'UID');
 		is_deeply($ret, {}, "out-of-range UID FETCH $r");
+		@w = grep(!/\boverload\.pm\b/, @w);
+		is_deeply(\@w, [], 'no unexpected warning');
 	}
+	$ret = $mic->fetch_hash(my $r = '558:559', 'UID');
+	is_deeply($ret, {}, "out-of-range UID FETCH $r");
 }
 
 for my $r ('1:*', '1') {

                 reply	other threads:[~2020-06-13 20:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200613202704.25602-1-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] t/imapd: quiet overload warning from Mail::IMAPClient' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).