user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] convert: describe the release of fast-import pipes
@ 2020-05-20  7:38 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-05-20  7:38 UTC (permalink / raw)
  To: meta

Upon rereading the code, it wasn't immediately obvious to
me why we didn't check for errors with `close($w)' instead
of relying on `undef'.  So add a comment for the benefit of
future readers.
 script/public-inbox-convert | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/public-inbox-convert b/script/public-inbox-convert
index 7fb15adf..dbb2bd38 100755
--- a/script/public-inbox-convert
+++ b/script/public-inbox-convert
@@ -144,10 +144,10 @@ while (<$rd>) {
 	last if $_ eq "done\n";
 	print $w $_ or $im->wfail;
-$w = $r = undef;
 close $rd or die "close fast-export: $!\n";
 waitpid($pid, 0) or die "waitpid failed: $!\n";
 $? == 0 or die "fast-export failed: $?\n";
+$r = $w = undef; # v2w->done does the actual close and error checking
 if (my $mm = $old->mm) {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-20  7:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20  7:38 [PATCH] convert: describe the release of fast-import pipes Eric Wong

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).