user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] index: v2: parallelize if --reindex or --jobs is specified
@ 2020-05-17  0:08 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-05-17  0:08 UTC (permalink / raw)
  To: meta

`--reindex' involves chomping down lots of mail, so it benefits
from parallelization just like the initial indexing.  It's
also a bit surprising to specify `--jobs/-j' without parallel
processes, so ensure we turn on parallelization there, too.

We can simplify initialization here, as well, since neither
`eval' nor `V2Writable->new' should be in this code.
---
 lib/PublicInbox/Admin.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index 2c8d191a..e42b01e0 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -191,9 +191,8 @@ sub index_inbox {
 	if (ref($ibx) && $ibx->version == 2) {
 		eval { require PublicInbox::V2Writable };
 		die "v2 requirements not met: $@\n" if $@;
-		my $v2w = $im // eval { $ibx->importer(0) } || eval {
-			PublicInbox::V2Writable->new($ibx, {nproc=>$jobs});
-		};
+		$ibx->{-creat_opt}->{nproc} = $jobs;
+		my $v2w = $im // $ibx->importer($opt->{reindex} // $jobs);
 		if (defined $jobs) {
 			if ($jobs == 0) {
 				$v2w->{parallel} = 0;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-17  0:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-17  0:08 [PATCH] index: v2: parallelize if --reindex or --jobs is specified Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).