user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: Re: [PATCH 5/5] spawn: use ~/.cache/public-inbox/inline-c if writable
Date: Mon, 11 May 2020 00:29:27 +0000	[thread overview]
Message-ID: <20200511002927.GA13730@dcvr> (raw)
In-Reply-To: <20200510223715.19254-6-e@yhbt.net>

Eric Wong <e@yhbt.net> wrote:
> -my $inline_dir = $ENV{PERL_INLINE_DIRECTORY};
> -$vfork_spawn = undef unless defined $inline_dir && -d $inline_dir && -w _;
> +my $inline_dir = $ENV{PERL_INLINE_DIRECTORY} // (
> +		$ENV{XDG_CACHE_HOME} //
> +		(($ENV{HOME} // (getpwuid($>))[7]).'/.cache')

Erm, nobody runs perl with setuid, anyways, right?

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 489472502fa..eaebb062393 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -143,7 +143,7 @@ VFORK_SPAWN
 
 my $inline_dir = $ENV{PERL_INLINE_DIRECTORY} // (
 		$ENV{XDG_CACHE_HOME} //
-		(($ENV{HOME} // (getpwuid($>))[7]).'/.cache')
+		(($ENV{HOME} // (getpwuid($<))[7]).'/.cache')
 	).'/public-inbox/inline-c';
 
 $vfork_spawn = undef unless -d $inline_dir && -w _;

On the other hand, I'm not sure if the getpwuid call is even
worth it when we can hard-code "/nonexistent" for "nobody"
when $HOME is undefined...

  reply	other threads:[~2020-05-11  0:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 22:37 [PATCH 0/5] scattered dev/CLI-oriented changes Eric Wong
2020-05-10 22:37 ` [PATCH 1/5] xt/eml_check_limits: check limits against an inbox Eric Wong
2020-05-10 22:37 ` [PATCH 2/5] rename "ContentId" to "ContentHash" Eric Wong
2020-05-10 22:37 ` [PATCH 3/5] overidx: document the SQLite PRAGMA we use Eric Wong
2020-05-10 22:37 ` [PATCH 4/5] msgmap: use TRUNCATE for journal_mode, for now Eric Wong
2020-05-10 22:37 ` [PATCH 5/5] spawn: use ~/.cache/public-inbox/inline-c if writable Eric Wong
2020-05-11  0:29   ` Eric Wong [this message]
2020-05-11  4:27     ` [PATCH v2] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511002927.GA13730@dcvr \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).