From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9FB251FA05 for ; Tue, 21 Apr 2020 03:22:52 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/3] t/nntpd: die if we can't open stderr output Date: Tue, 21 Apr 2020 03:22:52 +0000 Message-Id: <20200421032252.9151-4-e@yhbt.net> In-Reply-To: <20200421032252.9151-1-e@yhbt.net> References: <20200421032252.9151-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We need to detect FS errors and bail out on the test if we can't open a file -nntpd was just writing to. --- t/nntpd.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/nntpd.t b/t/nntpd.t index 2d7280a5..5a3a62fb 100644 --- a/t/nntpd.t +++ b/t/nntpd.t @@ -329,12 +329,12 @@ Date: Fri, 02 Oct 1993 00:00:00 +0000 $n = $s = undef; $td->join; - my $eout = eval { - local $/; + is($?, 0, 'no error in exited process'); + my $eout = do { open my $fh, '<', $err or die "open $err failed: $!"; + local $/; <$fh>; }; - is($?, 0, 'no error in exited process'); unlike($eout, qr/wide/i, 'no Wide character warnings'); }