user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] qspawn: remove Perl 5.16.x leak workaround
@ 2020-04-17  9:33 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-04-17  9:33 UTC (permalink / raw)
  To: meta; +Cc: Konstantin Ryabitsev

It seems no longer necessary to workaround this Perl 5.16.3 bug
after the removal of anonymous subs from all of our internal
code in

Tested with repeated clones (both aborted and completed)
in a CentOS 7.x VM which was once able to reproduce leaks
before the workaround appeared in 2fc42236f72ad16a
("qspawn: workaround Perl 5.16.3 leak, re-enable Deflater")

Cc: Konstantin Ryabitsev <>
 Oops, I intended to send this out shortly after 1.3.0 back in
 Feb; but forgot about the VM it was on after a power outage.

 lib/PublicInbox/ | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index aebcb1f7..c09e8d2c 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -281,10 +281,6 @@ sub psgi_return_init_cb {
 					${$self->{hdr_buf}}, $filter);
-	# Workaround a leak under Perl 5.16.3 when combined with
-	# Plack::Middleware::Deflater:
-	$wcb = undef;
 sub psgi_return_start { # may run later, much later...

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-17  9:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17  9:33 [PATCH] qspawn: remove Perl 5.16.x leak workaround Eric Wong

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).