From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/6] wwwlisting: favor "use" over require
Date: Thu, 19 Mar 2020 03:32:52 -0500 [thread overview]
Message-ID: <20200319083256.15593-3-e@yhbt.net> (raw)
In-Reply-To: <20200319083256.15593-1-e@yhbt.net>
"use" is also evaluated earlier than "require", so it is
favorable for compile-only checking.
---
lib/PublicInbox/WwwListing.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index c063fca6..a8aecaf7 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -12,8 +12,8 @@ use PublicInbox::View;
use PublicInbox::Inbox;
use bytes ();
use HTTP::Date qw(time2str);
-require Digest::SHA;
-require File::Spec;
+use Digest::SHA ();
+use File::Spec ();
*try_cat = \&PublicInbox::Inbox::try_cat;
sub list_all_i {
next prev parent reply other threads:[~2020-03-19 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 8:32 [PATCH 0/6] daemon: reduce fragmentation via preload Eric Wong
2020-03-19 8:32 ` [PATCH 1/6] www: update ->preload for newer modules Eric Wong
2020-03-19 8:32 ` Eric Wong [this message]
2020-03-19 8:32 ` [PATCH 3/6] wwwlisting: avoid lazy loading JSON module Eric Wong
2020-03-21 1:10 ` [PATCH 0/2] wwwlisting: fixup warnings :x Eric Wong
2020-03-21 1:10 ` [PATCH 1/2] wwwlisting: use first successfully loaded JSON module Eric Wong
2020-03-21 1:10 ` [PATCH 2/2] t/www_listing: avoid 'once' warnings Eric Wong
2020-03-21 5:24 ` [PATCH v2] " Eric Wong
2020-03-19 8:32 ` [PATCH 4/6] www: avoid `state' usage to perform allocations up-front Eric Wong
2020-03-19 8:32 ` [PATCH 5/6] daemon: do more immortal allocations up front Eric Wong
2020-03-19 8:32 ` [PATCH 6/6] viewdiff: favor `qr' to precompile regexps Eric Wong
2020-04-21 8:52 ` Encode preloading Eric Wong
2020-05-08 1:59 ` [PATCH] www: preload: load all encodings at startup Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319083256.15593-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).