user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] t/msg_iter: test for X-UNKNOWN charset from Alpine
Date: Fri, 14 Feb 2020 07:05:22 +0000	[thread overview]
Message-ID: <20200214070522.25535-1-e@yhbt.net> (raw)

A long overdue test for behavior established in 2016.

Fixes: 1b28cc7f00a866cb ("view: try assuming UTF-8 for bogus charsets")
---
 MANIFEST               |  1 +
 t/msg_iter.t           | 20 ++++++++++++++++++++
 t/x-unknown-alpine.eml | 21 +++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 t/x-unknown-alpine.eml

diff --git a/MANIFEST b/MANIFEST
index 5acd8531..48df274e 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -299,6 +299,7 @@ t/watch_maildir.t
 t/watch_maildir_v2.t
 t/www_listing.t
 t/www_static.t
+t/x-unknown-alpine.eml
 t/xcpdb-reshard.t
 xt/git-http-backend.t
 xt/git_async_cmp.t
diff --git a/t/msg_iter.t b/t/msg_iter.t
index de9c39fa..e33bfc69 100644
--- a/t/msg_iter.t
+++ b/t/msg_iter.t
@@ -4,6 +4,7 @@ use strict;
 use warnings;
 use Test::More;
 use Email::MIME;
+use PublicInbox::Hval qw(ascii_html);
 use_ok('PublicInbox::MsgIter');
 
 {
@@ -58,5 +59,24 @@ use_ok('PublicInbox::MsgIter');
 	is(index($raw, '$$$'), -1, 'no unescaped $$$');
 }
 
+{
+	my $f = 't/x-unknown-alpine.eml';
+	my $mime = Email::MIME->new(do {
+		open my $fh, '<', $f or die "open($f): $!";
+		local $/;
+		binmode $fh;
+		<$fh>;
+	});
+	my $raw = '';
+	msg_iter($mime, sub {
+		my ($part, $level, @ex) = @{$_[0]};
+		my ($s, $err) = msg_part_text($part, 'text/plain');
+		$raw .= $s;
+	});
+	like($raw, qr!^\thttps://!ms, 'tab expanded with X-UNKNOWN');
+	like(ascii_html($raw), qr/&#8226; bullet point/s,
+		'got bullet point when X-UNKNOWN assumes UTF-8');
+}
+
 done_testing();
 1;
diff --git a/t/x-unknown-alpine.eml b/t/x-unknown-alpine.eml
new file mode 100644
index 00000000..75b0bc55
--- /dev/null
+++ b/t/x-unknown-alpine.eml
@@ -0,0 +1,21 @@
+Date:	Sat, 13 Aug 2016 12:14:15 +0200 (CEST)
+From:	Alpine User <a@example.com>
+To: <list@example.com>
+Subject: charset=X-UNKNOWN test
+Message-ID: <alpine.DEB.2.20.1608131214070.4924@example>
+User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
+MIME-Version: 1.0
+Content-Type: multipart/mixed; BOUNDARY="8323329-703494712-1471083256=:4924"
+
+  This message is in MIME format.  The first part should be readable text,
+  while the remaining parts are likely unreadable without MIME-aware tools.
+
+--8323329-703494712-1471083256=:4924
+Content-Type: text/plain; charset=X-UNKNOWN
+Content-Transfer-Encoding: QUOTED-PRINTABLE
+
+=09https://example.com/
+
+  =E2=80=A2 bullet point
+
+--8323329-703494712-1471083256=:4924--

                 reply	other threads:[~2020-02-14  7:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214070522.25535-1-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).