From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/2] hval: from_attr: move to unit test
Date: Sun, 19 Jan 2020 09:40:52 +0000 [thread overview]
Message-ID: <20200119094052.11772-3-e@yhbt.net> (raw)
In-Reply-To: <20200119094052.11772-1-e@yhbt.net>
We don't call from_attr anywhere outside of tests, so don't
bloat normal processes with it.
---
lib/PublicInbox/Hval.pm | 15 +--------------
t/hval.t | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 39256ee0..2589c519 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -10,7 +10,7 @@ use Encode qw(find_encoding);
use PublicInbox::MID qw/mid_clean mid_escape/;
use base qw/Exporter/;
our @EXPORT_OK = qw/ascii_html obfuscate_addrs to_filename src_escape
- to_attr from_attr prurl/;
+ to_attr prurl/;
my $enc_ascii = find_encoding('us-ascii');
# safe-ish acceptable filename pattern for portability
@@ -148,17 +148,4 @@ sub to_attr ($) {
$first . $str;
}
-# reverse the result of to_attr
-sub from_attr ($) {
- my ($str) = @_;
- my $first = '';
- if ($str =~ s/\AZ([a-f0-9]{2})//ms) {
- $first = chr(hex($1));
- }
- $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms;
- $str =~ tr!:!/!;
- utf8::decode($str);
- $first . $str;
-}
-
1;
diff --git a/t/hval.t b/t/hval.t
index f93d6be6..53f52f07 100644
--- a/t/hval.t
+++ b/t/hval.t
@@ -3,7 +3,20 @@
use strict;
use warnings;
use Test::More;
-use_ok 'PublicInbox::Hval', qw(from_attr to_attr);
+use_ok 'PublicInbox::Hval', qw(to_attr);
+
+# reverse the result of to_attr
+sub from_attr ($) {
+ my ($str) = @_;
+ my $first = '';
+ if ($str =~ s/\AZ([a-f0-9]{2})//ms) {
+ $first = chr(hex($1));
+ }
+ $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms;
+ $str =~ tr!:!/!;
+ utf8::decode($str);
+ $first . $str;
+}
my $ibx = {
-no_obfuscate_re => qr/(?:example\.com)\z/i,
prev parent reply other threads:[~2020-01-19 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 9:40 [PATCH 0/2] hval: handle wide characters properly Eric Wong
2020-01-19 9:40 ` [PATCH 1/2] hval: to_attr: support wide characters Eric Wong
2020-01-19 9:40 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119094052.11772-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).