From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 536D31FD51 for ; Fri, 10 Jan 2020 09:14:20 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 4/5] git: remove ->commit_title method Date: Fri, 10 Jan 2020 09:14:18 +0000 Message-Id: <20200110091419.12340-5-e@yhbt.net> In-Reply-To: <20200110091419.12340-1-e@yhbt.net> References: <20200110091419.12340-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We haven't used it in SolverGit, yet, and I'll be reworking it to work with ->cat_async, instead. --- lib/PublicInbox/Git.pm | 7 ------- t/solver_git.t | 6 ------ 2 files changed, 13 deletions(-) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 9d0f660b..f3b7a0a0 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -332,13 +332,6 @@ sub cat_async ($$$;$) { push(@$inflight, [ $cb, $arg ]); } -sub commit_title ($$) { - my ($self, $oid) = @_; # PublicInbox::Git, $sha1hex - my $buf = cat_file($self, $oid) or return; - utf8::decode($$buf); - ($$buf =~ /\r?\n\r?\n([^\r\n]+)\r?\n?/)[0] -} - sub extract_cmt_time { my ($bref, undef, undef, undef, $modified) = @_; diff --git a/t/solver_git.t b/t/solver_git.t index 7c5619a7..67ae02e6 100644 --- a/t/solver_git.t +++ b/t/solver_git.t @@ -38,12 +38,6 @@ $deliver_patch->('t/solve/0001-simple-mod.patch'); my $v1_0_0_tag = 'cb7c42b1e15577ed2215356a2bf925aef59cdd8d'; my $git = PublicInbox::Git->new($git_dir); -is('public-inbox 1.0.0', - $git->commit_title($v1_0_0_tag), - 'commit_title works on 1.0.0'); - -is(undef, $git->commit_title('impossible'), 'undef on impossible object'); - $ibx->{-repo_objs} = [ $git ]; my $res; my $solver = PublicInbox::SolverGit->new($ibx, sub { $res = $_[0] });