user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] tests: remove some "git config" calls after "git init"
@ 2020-01-05  0:06 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-01-05  0:06 UTC (permalink / raw)
  To: meta

Creating a hash and iterating through it just to run "git
config" is ugly and slow.  Just write out the text file in a
human-friendly way since the git-config file format is stable
and won't break randomly.
---
 t/cgi.t   | 18 ++++++++----------
 t/mda.t   | 15 +++++++--------
 t/plack.t | 20 +++++++++-----------
 3 files changed, 24 insertions(+), 29 deletions(-)

diff --git a/t/cgi.t b/t/cgi.t
index 424b738e..90543a7a 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -13,7 +13,6 @@ my $pi_home = "$home/.public-inbox";
 my $pi_config = "$pi_home/config";
 my $maindir = "$tmpdir/main.git";
 my $addr = 'test-public@example.com';
-my $cfgpfx = "publicinbox.test";
 
 {
 	is(1, mkdir($home, 0755), "setup ~/ for testing");
@@ -23,15 +22,14 @@ my $cfgpfx = "publicinbox.test";
 	open my $fh, '>', "$maindir/description" or die "open: $!\n";
 	print $fh "test for public-inbox\n";
 	close $fh or die "close: $!\n";
-	my %cfg = (
-		"$cfgpfx.address" => $addr,
-		"$cfgpfx.inboxdir" => $maindir,
-		"$cfgpfx.indexlevel" => 'basic',
-	);
-	while (my ($k,$v) = each %cfg) {
-		is(0, system(qw(git config --file), $pi_config, $k, $v),
-			"setup $k");
-	}
+	open $fh, '>>', $pi_config or die;
+	print $fh <<EOF or die;
+[publicinbox "test"]
+	address = $addr
+	inboxdir = $maindir
+	indexlevel = basic
+EOF
+	close $fh or die "close: $!\n";
 }
 
 use_ok 'PublicInbox::Git';
diff --git a/t/mda.t b/t/mda.t
index 4556e323..631bb861 100644
--- a/t/mda.t
+++ b/t/mda.t
@@ -49,14 +49,13 @@ my $fail_bad_header = sub ($$$) {
 	is(1, mkdir($pi_home, 0755), "setup ~/.public-inbox");
 	is(0, system(qw(git init -q --bare), $maindir), "git init (main)");
 
-	my %cfg = (
-		"$cfgpfx.address" => $addr,
-		"$cfgpfx.inboxdir" => $maindir,
-	);
-	while (my ($k,$v) = each %cfg) {
-		is(0, system(qw(git config --file), $pi_config, $k, $v),
-			"setup $k");
-	}
+	open my $fh, '>>', $pi_config or die;
+	print $fh <<EOF or die;
+[publicinbox "test"]
+	address = $addr
+	inboxdir = $maindir
+EOF
+	close $fh or die;
 }
 
 local $ENV{GIT_COMMITTER_NAME} = eval {
diff --git a/t/plack.t b/t/plack.t
index f0dc4bbb..ec45b02c 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -10,7 +10,6 @@ my ($tmpdir, $for_destroy) = tmpdir();
 my $pi_config = "$tmpdir/config";
 my $maindir = "$tmpdir/main.git";
 my $addr = 'test-public@example.com';
-my $cfgpfx = "publicinbox.test";
 my @mods = qw(HTTP::Request::Common Plack::Test URI::Escape);
 require_mods(@mods);
 use_ok 'PublicInbox::Import';
@@ -24,16 +23,15 @@ foreach my $mod (@mods) { use_ok $mod; }
 	open my $fh, '>', "$maindir/description" or die "open: $!\n";
 	print $fh "test for public-inbox\n";
 	close $fh or die "close: $!\n";
-	my %cfg = (
-		"$cfgpfx.address" => $addr,
-		"$cfgpfx.inboxdir" => $maindir,
-		"$cfgpfx.url" => 'http://example.com/test/',
-		"$cfgpfx.newsgroup" => 'inbox.test',
-	);
-	while (my ($k,$v) = each %cfg) {
-		is(0, system(qw(git config --file), $pi_config, $k, $v),
-			"setup $k");
-	}
+	open $fh, '>>', $pi_config or die;
+	print $fh <<EOF or die;
+[publicinbox "test"]
+	address = $addr
+	inboxdir = $maindir
+	url = http://example.com/test/
+	newsgroup = inbox.test
+EOF
+	close $fh or die;
 
 	# ensure successful message delivery
 	{

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-05  0:06 [PATCH] tests: remove some "git config" calls after "git init" Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git