user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <>
To: "SZEDER Gábor" <>
Subject: [PATCH] viewdiff: do not anchor spaces after filenames in diffstat
Date: Sat, 4 Jan 2020 09:16:21 +0000
Message-ID: <20200104091621.GA25644@dcvr> (raw)
In-Reply-To: <>

SZEDER Gábor <> wrote:
> On Fri, Jul 05, 2019 at 04:06:18AM +0000, Eric Wong wrote:
> > Eric Wong <> wrote:
> > > SZEDER Gábor <> wrote:
> > > >
> > 
> > Btw, I'm not sure if the "(new +x)" and all the surrounding
> > spaces should be clickable.  I have poor coordination, so when I
> > (rarely) use a mouse I prefer bigger targets to click; but maybe
> > it can get confusing...
> FWIW, I didn't find it odd or surprising that the "(new +x)" is part
> of the link, and its color clearly indicates that it is part of the
> link.
> I haven't yet noticed that all the spaces following the filename are
> clickable as well, because they don't look like part of the link
> (well, being spaces, they don't have any color...), and haven't
> noticed the cursor changing shape when hovering over them.
> I'm not so sure about this, and think that it can be
> confusing/undesired in some circumstances.  A user can click on any
> "inactive" part of the browser window (i.e. what isn't a link, a
> button, or any active GUI widget) to focus and raise the window
> without any other effects, so they might just happen to click on
> those unsuspicious spaces because they don't look like a link, and
> then be surprised when the page jumps to corresponding diff.

OK, I didn't realize how bad the problem is, since I mainly
use w3m for web development and that doesn't underline links
by default.  Will push this out soon:

Subject: [PATCH] viewdiff: do not anchor spaces after filenames in diffstat

Viewing a CSS-less page in a browser which underlines links
can show a long line of underscores after diffstats.  Not all
browsers underline links by default, though.
 lib/PublicInbox/ | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 4669e874..4d72eb48 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -104,8 +104,9 @@ sub anchor0 ($$$$$) {
 	if (my $attr = to_attr($ctx->{-apfx}.$fn)) {
 		$ctx->{-anchors}->{$attr} = 1;
+		my $spaces = ($orig =~ s/( +)\z//) ? $1 : '';
 		$$dst .= " <a\nid=i$attr\nhref=#$attr>" .
-			ascii_html($orig) . '</a>'.
+			ascii_html($orig) . '</a>' . $spaces .
 			to_html($linkify, $rest);
 		return 1;

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 23:11 broken link in diffstat for new files SZEDER Gábor
2019-07-05  4:03 ` [PATCH] viewdiff: do not anchor using diffstat comments Eric Wong
2019-07-05  4:06   ` Eric Wong
2019-07-05  8:55     ` SZEDER Gábor
2020-01-04  9:16       ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200104091621.GA25644@dcvr \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone