From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/6] build: remove NEWS from dist-git target
Date: Wed, 1 Jan 2020 09:57:51 +0000 [thread overview]
Message-ID: <20200101095755.31325-3-e@80x24.org> (raw)
In-Reply-To: <20200101095755.31325-1-e@80x24.org>
mknews doesn't require any optional dependencies a user wouldn't
normally have. We can save storage and bandwidth costs by
letting cgit serve the exact tar.gz which "git archive | gzip -n"
generates.
---
Documentation/include.mk | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk
index f2605346..0229bf40 100644
--- a/Documentation/include.mk
+++ b/Documentation/include.mk
@@ -109,15 +109,14 @@ clean-doc:
clean :: clean-doc
# No camel-cased tarballs or pathnames which MakeMaker creates,
-# this may not always be a Perl project.
-git-dist :: ver = $(shell git describe |sed -ne 's/v//p')
-git-dist :: pkgpfx := public-inbox-$(ver)
-git-dist :: NEWS
- git archive --prefix=$(pkgpfx)/ --format=tar HEAD^{tree} >$(pkgpfx).tar
- mkdir -p $(pkgpfx)
- cp NEWS $(pkgpfx)/NEWS
- $(TAR) rf $(pkgpfx).tar $(pkgpfx)/NEWS
- $(RM) $(pkgpfx)/NEWS
- rmdir $(pkgpfx)
- gzip -9 $(pkgpfx).tar
- @echo $(pkgpfx).tar.gz created
+# this may not always be a Perl project. This should match what
+# cgit generate, since git maintainers ensure git-archive has
+# stable tar output
+DIST_TREE = HEAD^{tree}
+DIST_VER =
+git-dist :
+ ver=$$(git describe $(DIST_VER) | sed -ne s/v//p); \
+ pkgpfx=public-inbox-$$ver; \
+ git archive --prefix=$$pkgpfx/ --format=tar $(DIST_TREE) \
+ | gzip -n >$$pkgpfx.tar.gz; \
+ echo $$pkgpfx.tar.gz created
next prev parent reply other threads:[~2020-01-01 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 9:57 [PATCH 0/6] doc updates and such Eric Wong
2020-01-01 9:57 ` [PATCH 1/6] doc: allow NEWS file to be built without Plack::Util Eric Wong
2020-01-01 9:57 ` Eric Wong [this message]
2020-01-01 9:57 ` [PATCH 3/6] doc: release notes: set Date for 1.2.0, start 1.3.0 Eric Wong
2020-01-01 9:57 ` [PATCH 4/6] doc/txt2pre: flush output before utime() Eric Wong
2020-01-01 9:57 ` [PATCH 5/6] build: fix xapian-* manpage generation Eric Wong
2020-01-01 9:57 ` [PATCH 6/6] doc: fix a few spelling errors in user-facing docs Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200101095755.31325-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).