From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E4E6A1F463 for ; Mon, 16 Dec 2019 08:07:34 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] t/edit.t: drop redundant "delete local $ENV{...}" Date: Mon, 16 Dec 2019 08:07:34 +0000 Message-Id: <20191216080734.23016-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: "delete local" is only in Perl v5.11.0, and we only depend on Perl v5.10.1. We already localize and delete it as two separate statements immediately above. I wish this was hidden behind a "use feature" flag like other new-fangled things :<. Oh well, I think the oldest Perl actually in use for this project is 5.16 (CentOS 7.x). --- t/edit.t | 1 - 1 file changed, 1 deletion(-) diff --git a/t/edit.t b/t/edit.t index 02df6cda..122aa19f 100644 --- a/t/edit.t +++ b/t/edit.t @@ -129,7 +129,6 @@ $t = 'mailEditor set in config'; { is($rc, 0, 'set publicinbox.mailEditor'); local $ENV{MAIL_EDITOR}; delete $ENV{MAIL_EDITOR}; - delete local $ENV{MAIL_EDITOR}; local $ENV{GIT_EDITOR} = 'echo should not run'; $cmd = [ '-edit', "-m$mid", $inboxdir ]; ok(run_script($cmd, undef, $opt), "$t edited message");