user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] replace: quiet "git gc" invocation
Date: Thu, 28 Nov 2019 20:54:35 +0000	[thread overview]
Message-ID: <20191128205435.21704-3-e@80x24.org> (raw)
In-Reply-To: <20191128205435.21704-1-e@80x24.org>

Since we give users no indication or control of how "git gc"
runs, showing its progress is confusing.
---
 lib/PublicInbox/Import.pm     | 2 +-
 lib/PublicInbox/V2Writable.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index cb25215d..8a369ee4 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -595,7 +595,7 @@ sub replace_oids {
 
 	return if $nreplace == 0;
 
-	run_die([@git, qw(-c gc.reflogExpire=now gc --prune=all)]);
+	run_die([@git, qw(-c gc.reflogExpire=now gc --prune=all --quiet)]);
 
 	# check that old OIDs are gone
 	my $err = 0;
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 02f313b0..ab80941a 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1204,7 +1204,7 @@ sub unindex ($$$$) {
 
 	# ensure any blob can not longer be accessed via dumb HTTP
 	PublicInbox::Import::run_die(['git', "--git-dir=$git->{git_dir}",
-		qw(-c gc.reflogExpire=now gc --prune=all)]);
+		qw(-c gc.reflogExpire=now gc --prune=all --quiet)]);
 }
 
 sub sync_ranges ($$$) {

      parent reply	other threads:[~2019-11-28 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 20:54 [PATCH 0/2] replace: quiet down git commands Eric Wong
2019-11-28 20:54 ` [PATCH 1/2] t/replace: quiet "git fsck" invocation Eric Wong
2019-11-28 20:54 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128205435.21704-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).