user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] mboxgz: fix compiler parse error under under Perl 5.16.3
@ 2019-11-24  3:19 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-11-24  3:19 UTC (permalink / raw)
  To: meta

Perl 5.16.3 (and possibly older versions) fails with the
following errors (from CentOS7):

  Use of ?PATTERN? without explicit operator is deprecated
  Search pattern not terminated
---
 lib/PublicInbox/MboxGz.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm
index 2a55447f..1621cff8 100644
--- a/lib/PublicInbox/MboxGz.pm
+++ b/lib/PublicInbox/MboxGz.pm
@@ -63,7 +63,7 @@ sub getline {
 	# signal that we're done and can return undef next call:
 	delete $self->{ctx};
 	my $err = $gz->flush($buf, Z_FINISH);
-	$err == Z_OK ? $buf : gzip_fail($ctx, $err);
+	($err == Z_OK) ? $buf : gzip_fail($ctx, $err);
 }
 
 sub close {} # noop

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-24  3:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-24  3:19 [PATCH] mboxgz: fix compiler parse error under under Perl 5.16.3 Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).