user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 2/2] edit: check for write errors writing "From_" line
Date: Fri,  8 Nov 2019 20:20:18 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

We need to check every print to a regular file for errors,
because storage devices inevitably fail.
 script/public-inbox-edit | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/script/public-inbox-edit b/script/public-inbox-edit
index 24b7ed8b..43ce9900 100755
--- a/script/public-inbox-edit
+++ b/script/public-inbox-edit
@@ -130,7 +130,8 @@ foreach my $to_edit (values %$found) {
 	my $tmp = $$old_raw;
 	if (!$opt->{raw}) {
 		my $oid = $smsg->{blob};
-		print $edit_fh "From mboxrd\@$oid Thu Jan  1 00:00:00 1970\n";
+		print $edit_fh "From mboxrd\@$oid Thu Jan  1 00:00:00 1970\n"
+			or die "failed to write From_ line: $!";
 		$tmp =~ s/^(>*From )/>$1/gm;
 	print $edit_fh $tmp or

      parent reply	other threads:[~2019-11-08 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 20:20 [PATCH 0/2] edit: minor bug fixes Eric Wong
2019-11-08 20:20 ` [PATCH 1/2] edit: propagate correct editor exit code Eric Wong
2019-11-08 20:20 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --subject='Re: [PATCH 2/2] edit: check for write errors writing "From_" line' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).