From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/httpd-corner.t: check for curl(1) errors in big async test
Date: Mon, 4 Nov 2019 02:27:23 +0000 [thread overview]
Message-ID: <20191104022723.90186-1-e@80x24.org> (raw)
curl(1) can fail and we need to invalidate the test in the
rare case it fails.
---
t/httpd-corner.t | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/httpd-corner.t b/t/httpd-corner.t
index 4077a6d1..fbba4623 100644
--- a/t/httpd-corner.t
+++ b/t/httpd-corner.t
@@ -272,6 +272,7 @@ SKIP: {
$n += $r;
$buf =~ /\A\0+\z/ or $non_zero++;
}
+ close $fh or die "curl errored out \$?=$?";
is($n, 30 * 1024 * 1024, 'got expected output from curl');
is($non_zero, 0, 'read all zeros');
}
--
EW
reply other threads:[~2019-11-04 2:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104022723.90186-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).