From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] HACKING: add a note about avoiding recursion
Date: Thu, 24 Oct 2019 21:09:42 +0000 [thread overview]
Message-ID: <20191024210942.25566-1-e@80x24.org> (raw)
Bad things happen when user data can control our stack size.
---
Maybe there's programming languages where deep recursion isn't
a problem, but they're not widely available on common GNU/Linux
or *BSD systems.
HACKING | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/HACKING b/HACKING
index 666d504e..859745ef 100644
--- a/HACKING
+++ b/HACKING
@@ -43,6 +43,11 @@ distribute and verify. public-inbox itself will only be implemented
in scripting languages (currently Perl 5) and optional JIT-compiled C
(via Inline::C)
+Do not recurse on user-supplied data. Neither Perl or C handle
+deep recursion gracefully. See lib/PublicInbox/SearchThread.pm
+and lib/PublicInbox/MsgIter.pm for examples of non-recursive
+alternatives to previously-recursive algorithms.
+
Performance should be reasonably good for server administrators, too,
and we will sacrifice features to achieve predictable performance.
Encouraging folks to self-host will be easier with lower hardware
reply other threads:[~2019-10-24 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024210942.25566-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).