From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/2] config: remove redundant inboxdir check
Date: Wed, 16 Oct 2019 09:59:37 +0000 [thread overview]
Message-ID: <20191016095937.GA24529@dcvr> (raw)
In-Reply-To: <20191016085955.23674-1-e@80x24.org>
This was causing compatibility problems for old configs
when using public-inbox-nntpd.
---
lib/PublicInbox/Config.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 2da202f9..bdde3dbc 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -93,7 +93,6 @@ sub each_inbox {
# may auto-vivify if config file is non-existent:
foreach my $section (@{$self->{-section_order}}) {
next if $section !~ m!\Apublicinbox\.([^/]+)\z!;
- defined($self->{"publicinbox.$1.inboxdir"}) or next;
my $ibx = lookup_name($self, $1) or next;
$cb->($ibx);
}
@@ -389,7 +388,7 @@ sub _fill {
}
}
- return unless $ibx->{inboxdir};
+ return unless defined($ibx->{inboxdir});
my $name = $pfx;
$name =~ s/\Apublicinbox\.//;
prev parent reply other threads:[~2019-10-16 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 8:59 [PATCH 0/2] rename "mainrepo" to "inboxdir" Eric Wong
2019-10-16 8:59 ` [PATCH 1/2] examples/grok-pull.post_update_hook: use "inbox_dir" Eric Wong
2019-10-16 8:59 ` [PATCH 2/2] config: support "inboxdir" in addition to "mainrepo" Eric Wong
2019-10-16 9:59 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016095937.GA24529@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).