From: Eric Wong <e@80x24.org> To: "Eric W. Biederman" <ebiederm@xmission.com> Cc: meta@public-inbox.org Subject: ibx->{listid} autoviv fixup [was: [PATCH 0/4] Various bits to support import_imap_mailbox] Date: Thu, 10 Oct 2019 19:08:26 +0000 Message-ID: <20191010190826.GA5440@dcvr> (raw) In-Reply-To: <87wode9vxw.fsf_-_@x220.int.ebiederm.org> "Eric W. Biederman" <ebiederm@xmission.com> wrote: > Eric Wong, > > These should all of my generic patches to support my import_imap_mailbox > script. The really important patch that adds to the support for List-ID > to public inbox configuration file I have already sent. > > I haven't written tests and I get the following test failure when I run > make test > > > t/config.t ................. 1/? > > # Failed test 'lookup matches expected output' > > # at t/config.t line 26. > > # Structures begin differing at: > > # $got->{listid} = ARRAY(0x55c1d4e3b6a8) > > # $expected->{listid} = Does not exist > > > > # Failed test 'lookup matches expected output for test' > > # at t/config.t line 42. > > # Structures begin differing at: > > # $got->{listid} = ARRAY(0x55c1d508d8d0) > > # $expected->{listid} = Does not exist > > # Looks like you failed 2 tests of 69. > > t/config.t ................. Dubious, test returned 2 (wstat 512, 0x200) > > I haven't looked into what is happening there. Hey Eric, I'll squash this in to fix the tests: diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index 9f3f8df7..c2fa40f9 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -449,8 +449,10 @@ sub _fill { $self->{-by_addr}->{$lc_addr} = $ibx; $self->{-no_obfuscate}->{$lc_addr} = 1; } - foreach my $list_id (@{$ibx->{listid}}) { - $self->{-by_list_id}->{$list_id} = $ibx; + if (my $listids = $ibx->{listid}) { + foreach my $list_id (@$listids) { + $self->{-by_list_id}->{$list_id} = $ibx; + } } if (my $ng = $ibx->{newsgroup}) { $self->{-by_newsgroup}->{$ng} = $ibx; Perl has this weird feature where it autovivifies arrayrefs (and hashrefs) on member access.
next prev parent reply other threads:[~2019-10-10 19:08 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-07 22:13 Do I need multiple publicinbox.<name>.address values? Alyssa Ross 2019-10-08 0:10 ` Eric Wong 2019-10-08 12:18 ` Eric W. Biederman 2019-10-08 12:23 ` [PATCH] Config.pm: Add support for mailing list information Eric W. Biederman 2019-10-08 22:11 ` Do I need multiple publicinbox.<name>.address values? Eric Wong 2019-10-08 22:24 ` Eric W. Biederman 2019-10-08 22:41 ` Eric Wong 2019-10-09 7:58 ` Eric W. Biederman 2019-10-09 8:15 ` [PATCH 0/4] Various bits to support import_imap_mailbox Eric W. Biederman 2019-10-09 8:16 ` [PATCH 1/4] PublicInbox::Import Smuggle a raw message into add Eric W. Biederman 2019-10-15 20:26 ` Eric Wong 2019-10-15 23:05 ` Eric W. Biederman 2019-10-09 8:17 ` [PATCH 2/4] PublicInbox::Config: Process mailboxes in sorted order Eric W. Biederman 2019-10-10 9:43 ` Eric Wong 2019-10-10 11:05 ` Eric W. Biederman 2019-10-09 8:23 ` [PATCH 3/4] Config.pm: Add support for looking up repos by their directories Eric W. Biederman 2019-10-09 8:25 ` [PATCH 4/4] IMAPTracker: Add a helper to track our place in reading imap mailboxes Eric W. Biederman 2019-10-10 19:08 ` Eric Wong [this message] 2019-10-10 21:23 ` ibx->{listid} autoviv fixup [was: [PATCH 0/4] Various bits to support import_imap_mailbox] Eric W. Biederman 2019-10-10 8:31 ` Do I need multiple publicinbox.<name>.address values? Eric Wong 2019-10-10 10:56 ` Eric W. Biederman 2019-10-09 11:59 ` Alyssa Ross 2019-10-10 10:06 ` Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191010190826.GA5440@dcvr \ --to=e@80x24.org \ --cc=ebiederm@xmission.com \ --cc=meta@public-inbox.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
user/dev discussion of public-inbox itself This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/meta git clone --mirror http://czquwvybam4bgbro.onion/meta git clone --mirror http://hjrcffqmbrq6wope.onion/meta git clone --mirror http://ou63pmih66umazou.onion/meta # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \ meta@public-inbox.org public-inbox-index meta Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta nntp://news.gmane.io/gmane.mail.public-inbox.general note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/public-inbox.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git