From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D50281F463 for ; Thu, 26 Sep 2019 08:05:32 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] v2writable: only change $EPOCH.git/config on epoch creation Date: Thu, 26 Sep 2019 08:05:32 +0000 Message-Id: <20190926080532.30761-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We don't need to make unnecesary writes to the git config file and wear out storage devices every time we run "public-inbox-index" --- lib/PublicInbox/V2Writable.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 45250923..627bcba9 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -665,14 +665,10 @@ sub fill_alternates ($$) { my $pfx = "$self->{-inbox}->{mainrepo}/git"; my $all = "$self->{-inbox}->{mainrepo}/all.git"; - my @cmd; + unless (-d $all) { PublicInbox::Import::init_bare($all); } - @cmd = (qw/git config/, "--file=$pfx/$epoch.git/config", - 'include.path', '../../all.git/config'); - PublicInbox::Import::run_die(\@cmd); - my $alt = "$all/objects/info/alternates"; my %alts; my @add; @@ -697,6 +693,9 @@ sub git_init { my $git_dir = "$self->{-inbox}->{mainrepo}/git/$epoch.git"; my @cmd = (qw(git init --bare -q), $git_dir); PublicInbox::Import::run_die(\@cmd); + @cmd = (qw/git config/, "--file=$git_dir/config", + 'include.path', '../../all.git/config'); + PublicInbox::Import::run_die(\@cmd); fill_alternates($self, $epoch); $git_dir } -- EW