user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] v2writable: only change $EPOCH.git/config on epoch creation
@ 2019-09-26  8:05 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-09-26  8:05 UTC (permalink / raw)
  To: meta

We don't need to make unnecesary writes to the git config file
and wear out storage devices every time we run
"public-inbox-index"
---
 lib/PublicInbox/V2Writable.pm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 45250923..627bcba9 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -665,14 +665,10 @@ sub fill_alternates ($$) {
 
 	my $pfx = "$self->{-inbox}->{mainrepo}/git";
 	my $all = "$self->{-inbox}->{mainrepo}/all.git";
-	my @cmd;
+
 	unless (-d $all) {
 		PublicInbox::Import::init_bare($all);
 	}
-	@cmd = (qw/git config/, "--file=$pfx/$epoch.git/config",
-			'include.path', '../../all.git/config');
-	PublicInbox::Import::run_die(\@cmd);
-
 	my $alt = "$all/objects/info/alternates";
 	my %alts;
 	my @add;
@@ -697,6 +693,9 @@ sub git_init {
 	my $git_dir = "$self->{-inbox}->{mainrepo}/git/$epoch.git";
 	my @cmd = (qw(git init --bare -q), $git_dir);
 	PublicInbox::Import::run_die(\@cmd);
+	@cmd = (qw/git config/, "--file=$git_dir/config",
+			'include.path', '../../all.git/config');
+	PublicInbox::Import::run_die(\@cmd);
 	fill_alternates($self, $epoch);
 	$git_dir
 }
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26  8:05 [PATCH] v2writable: only change $EPOCH.git/config on epoch creation Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox