user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] v2writable: only change $EPOCH.git/config on epoch creation
Date: Thu, 26 Sep 2019 08:05:32 +0000	[thread overview]
Message-ID: <20190926080532.30761-1-e@80x24.org> (raw)

We don't need to make unnecesary writes to the git config file
and wear out storage devices every time we run
"public-inbox-index"
---
 lib/PublicInbox/V2Writable.pm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 45250923..627bcba9 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -665,14 +665,10 @@ sub fill_alternates ($$) {
 
 	my $pfx = "$self->{-inbox}->{mainrepo}/git";
 	my $all = "$self->{-inbox}->{mainrepo}/all.git";
-	my @cmd;
+
 	unless (-d $all) {
 		PublicInbox::Import::init_bare($all);
 	}
-	@cmd = (qw/git config/, "--file=$pfx/$epoch.git/config",
-			'include.path', '../../all.git/config');
-	PublicInbox::Import::run_die(\@cmd);
-
 	my $alt = "$all/objects/info/alternates";
 	my %alts;
 	my @add;
@@ -697,6 +693,9 @@ sub git_init {
 	my $git_dir = "$self->{-inbox}->{mainrepo}/git/$epoch.git";
 	my @cmd = (qw(git init --bare -q), $git_dir);
 	PublicInbox::Import::run_die(\@cmd);
+	@cmd = (qw/git config/, "--file=$git_dir/config",
+			'include.path', '../../all.git/config');
+	PublicInbox::Import::run_die(\@cmd);
 	fill_alternates($self, $epoch);
 	$git_dir
 }
-- 
EW


                 reply	other threads:[~2019-09-26  8:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926080532.30761-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).