From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 51BBB1F47A for ; Tue, 17 Sep 2019 08:31:24 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/6] http: drop unused `$env' variable after delete Date: Tue, 17 Sep 2019 08:31:22 +0000 Message-Id: <20190917083123.6468-6-e@80x24.org> In-Reply-To: <20190917083123.6468-1-e@80x24.org> References: <20190917083123.6468-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: And explain why we need to do that delete in a comment. --- lib/PublicInbox/HTTP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index b43ef87..cd95f4a 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -255,7 +255,7 @@ sub next_request ($) { sub response_done_cb ($$) { my ($self, $alive) = @_; sub { - my $env = delete $self->{env}; + delete $self->{env}; # we're no longer busy $self->write(\"0\r\n\r\n") if $alive == 2; $self->write($alive ? \&next_request : \&close); } -- EW