user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH] nntpdeflate: stop relying on SUPER for ->do_read
Date: Sat, 13 Jul 2019 20:27:57 +0000	[thread overview]
Message-ID: <> (raw)

We won't need further layering after enabling compression.  So
be explicit about which sub we're calling when we hit ->do_read
from NNTP and eliminate the need for the comment.
 lib/PublicInbox/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 10e2337c..f2de0f38 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -62,13 +62,13 @@ sub enable {
 # overrides PublicInbox::NNTP::compressed
 sub compressed { 1 }
-# SUPER is PublicInbox::DS::do_read, so $_[1] may be a reference or not
+# $_[1] may be a reference or not
 sub do_read ($$$$) {
 	my ($self, $rbuf, $len, $off) = @_;
 	my $zin = $self->{zin} or return; # closed
 	my $deflated = \($zin->[1]);
-	my $r = $self->SUPER::do_read($deflated, $len) or return;
+	my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return;
 	# assert(length($$rbuf) == $off) as far as is concerned
 	# -ConsumeInput is true, so $deflated is automatically emptied

                 reply	other threads:[~2019-07-13 20:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).