user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 3/3] http|nntp: "use PublicInbox::DS" instead of ->import
Date: Mon,  8 Jul 2019 07:39:05 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Relying on "use" to import during BEGIN means we get to take
advantage of prototype checking of function args during the rest
of the compilation phase.
 lib/PublicInbox/ | 2 +-
 lib/PublicInbox/ | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 5546ac46..60b287c4 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -19,7 +19,7 @@ use HTTP::Status qw(status_message);
 use HTTP::Date qw(time2str);
 use IO::Handle;
 require PublicInbox::EvCleanup;
+use PublicInbox::DS qw(msg_more);
 use PublicInbox::Syscall qw(EPOLLIN EPOLLONESHOT);
 use constant {
 	CHUNK_START => -1,   # [a-f0-9]+\r\n
diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 6fee29f4..6796a3c4 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -14,7 +14,7 @@ use PublicInbox::Git;
 require PublicInbox::EvCleanup;
 use Email::Simple;
 use POSIX qw(strftime);
+use PublicInbox::DS qw(now);
 use Digest::SHA qw(sha1_hex);
 use Time::Local qw(timegm timelocal);
 use constant {

      parent reply	other threads:[~2019-07-08  7:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08  7:39 [PATCH 0/3] a few minor cleanups Eric Wong
2019-07-08  7:39 ` [PATCH 1/3] daemon: use POSIX and WNOHANG more idiomatically Eric Wong
2019-07-08  7:39 ` [PATCH 2/3] httpd: (cleanup) use reference instead of *glob Eric Wong
2019-07-08  7:39 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).