user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] http: use MSG_MORE for identity callback, too
@ 2019-07-08  4:53 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-07-08  4:53 UTC (permalink / raw)
  To: meta

No point in using ->write to flush data out to a client
when the chunked callback also uses MSG_MORE to reduce
packets.
---
 lib/PublicInbox/HTTP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 5546ac46..1bd65331 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -237,7 +237,7 @@ sub chunked_wcb ($) {
 
 sub identity_wcb ($) {
 	my ($self) = @_;
-	sub { $self->write(\($_[0])) if $_[0] ne '' }
+	sub { msg_more($self, $_[0]) if $_[0] ne '' }
 }
 
 sub next_request ($) {
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-07-08  4:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08  4:53 [PATCH] http: use MSG_MORE for identity callback, too Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).