user/dev discussion of public-inbox itself
 help / color / Atom feed
* broken link in diffstat for new files
@ 2019-07-04 23:11 SZEDER Gábor
  2019-07-05  4:03 ` [PATCH] viewdiff: do not anchor using diffstat comments Eric Wong
  0 siblings, 1 reply; 4+ messages in thread
From: SZEDER Gábor @ 2019-07-04 23:11 UTC (permalink / raw)
  To: meta

Hi,

being able to jump around from diffstat to the diff of a particular
file and back by simply clicking on links is great, but it doesn't
seem to work with newly added files.  Consider this message:

  https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/

Clicking on the link that is the name of the doc source file or any of
the C source of header files in the diffstat jumps to the diff of the
particular file, but clicking on the link of any of the two new test
files doesn't go anywhere.  Conversely, in the "diff --git a/...
b/..." lines of the doc and source files the word "diff" is a link
pointing back to the diffstat, but in the diff lines of those two new
test files there is no link.

Several other patches in that patch series add new test files, and all
are affected by this issue.


Best,
Gábor

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 23:11 broken link in diffstat for new files SZEDER Gábor
2019-07-05  4:03 ` [PATCH] viewdiff: do not anchor using diffstat comments Eric Wong
2019-07-05  4:06   ` Eric Wong
2019-07-05  8:55     ` SZEDER Gábor

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox