From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, FROM_EXCESS_BASE64,PDS_NO_HELO_DNS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9C5AC1F4B6 for ; Fri, 5 Jul 2019 08:56:05 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id c2so9061799wrm.8 for ; Fri, 05 Jul 2019 01:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oJBTZiUrNU7cOHpkwA+U35HKR1PcVC4fy9g0ANoEZ3Y=; b=td2AIlnsEUQdk7c5Rb2kgcolRm8pw5PoSFn/7RQUwstqUNykeECJ8yMfA2w5Wanxgv 4EL55hefrHaFT3IYUmKF35p6wAJTJWlJ5kBvV49qsdnclTDX6AkQkZ1EXEK9iBI/6Nbj Brbbfa3sfjBKVtmpdA1L8pfGqf7RBOJRSSUL17KebWLLxbKABIby/Guz4sYOTZe3sZEB edvJIsNqy7/a6WpdbO7gQMXzN3wBS98lAo0tLEaABHkISX/lCxPsrjGqMexAwL0/Da6+ afnTBL6AInEuXnVQtYTaDjexszESRiG4II6K4XMLSrFdNU3jvJ00HAyp/5LBaAqlbooW N6Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oJBTZiUrNU7cOHpkwA+U35HKR1PcVC4fy9g0ANoEZ3Y=; b=EgMKGvwRk/Yj0edMkoUw9tLg4Lis5jbdMYFqnevhBU+P8K6P1W5taJwrLqFVw0yjLE 4AL4QGJZFjqrL6uvsD+edBN6SdEA6eF3MMpLZoQmzB6zth2KE6J/Bp5Fbh5TRkby3QOs YVEdVb+NgUxG8sAuircbcvPb0mwKT1fPeyVENLp531txv5lS3pd0kkNFCeY3TuC0qBqJ wEZBZhyEXtVEgjXYmwaMCCn0YnDPQTRbdziNlyOmsnsZzAuf3d7Ie46IVNSYBPH1f9yg m60AoUyR9mgDlpbVIrw392QlDW2crHhviumoZQHpglu5bsZ4FMexgRwhwcmXjf5MIGLd Aqog== X-Gm-Message-State: APjAAAXVxdyRdKGevuk+zUEB3OiW88R89KE/cTdFeIgbcbaMe0LSJrhC sNIaBUcdmWxafoW5x7zZCIM= X-Google-Smtp-Source: APXvYqyU/+orfg/6G+nBTE0wtndBp7hYCpnyDp3VaZ2rc/PNrrZKh8iuuGQMb40br/zkwmGLB+hW6A== X-Received: by 2002:adf:f3cc:: with SMTP id g12mr2781580wrp.149.1562316962559; Fri, 05 Jul 2019 01:56:02 -0700 (PDT) Received: from szeder.dev (x4db66efa.dyn.telefonica.de. [77.182.110.250]) by smtp.gmail.com with ESMTPSA id c6sm8190033wma.25.2019.07.05.01.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 01:56:01 -0700 (PDT) Date: Fri, 5 Jul 2019 10:55:59 +0200 From: SZEDER =?utf-8?B?R8OhYm9y?= To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] viewdiff: do not anchor using diffstat comments Message-ID: <20190705085559.GG20404@szeder.dev> References: <20190704231123.GF20404@szeder.dev> <20190705040311.GA2896@dcvr> <20190705040618.gnbg6jvzqqcn3i5e@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190705040618.gnbg6jvzqqcn3i5e@dcvr> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: On Fri, Jul 05, 2019 at 04:06:18AM +0000, Eric Wong wrote: > Eric Wong wrote: > > SZEDER Gábor wrote: > > > https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/ > > Btw, I'm not sure if the "(new +x)" and all the surrounding > spaces should be clickable. I have poor coordination, so when I > (rarely) use a mouse I prefer bigger targets to click; but maybe > it can get confusing... FWIW, I didn't find it odd or surprising that the "(new +x)" is part of the link, and its color clearly indicates that it is part of the link. I haven't yet noticed that all the spaces following the filename are clickable as well, because they don't look like part of the link (well, being spaces, they don't have any color...), and haven't noticed the cursor changing shape when hovering over them. I'm not so sure about this, and think that it can be confusing/undesired in some circumstances. A user can click on any "inactive" part of the browser window (i.e. what isn't a link, a button, or any active GUI widget) to focus and raise the window without any other effects, so they might just happen to click on those unsuspicious spaces because they don't look like a link, and then be surprised when the page jumps to corresponding diff.