user/dev discussion of public-inbox itself
 help / color / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: meta@public-inbox.org
Subject: broken link in diffstat for new files
Date: Fri, 5 Jul 2019 01:11:23 +0200
Message-ID: <20190704231123.GF20404@szeder.dev> (raw)

Hi,

being able to jump around from diffstat to the diff of a particular
file and back by simply clicking on links is great, but it doesn't
seem to work with newly added files.  Consider this message:

  https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/

Clicking on the link that is the name of the doc source file or any of
the C source of header files in the diffstat jumps to the diff of the
particular file, but clicking on the link of any of the two new test
files doesn't go anywhere.  Conversely, in the "diff --git a/...
b/..." lines of the doc and source files the word "diff" is a link
pointing back to the diffstat, but in the diff lines of those two new
test files there is no link.

Several other patches in that patch series add new test files, and all
are affected by this issue.


Best,
Gábor

             reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 23:11 SZEDER Gábor [this message]
2019-07-05  4:03 ` [PATCH] viewdiff: do not anchor using diffstat comments Eric Wong
2019-07-05  4:06   ` Eric Wong
2019-07-05  8:55     ` SZEDER Gábor
2020-01-04  9:16       ` [PATCH] viewdiff: do not anchor spaces after filenames in diffstat Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704231123.GF20404@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git