user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] t/nntpd*.t: require IO::Socket::SSL 2.007 for Net::NNTP tests
@ 2019-07-01  9:07 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-07-01  9:07 UTC (permalink / raw)
  To: meta

Net::NNTP won't attempt to use older versions of IO::Socket::SSL
because 2.007 is the "first version with default CA on most platforms"
according to comments in Net::NNTP.  But then again we don't make
remote requests when testing...
---
 t/nntpd-tls.t | 2 ++
 t/nntpd.t     | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index 4cf53daa..49b31221 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -13,6 +13,8 @@ foreach my $mod (qw(DBD::SQLite IO::Socket::SSL Net::NNTP IO::Poll)) {
 }
 Net::NNTP->can('starttls') or
 	plan skip_all => 'Net::NNTP does not support TLS';
+IO::Socket::SSL->VERSION(2.007) or
+	plan skip_all => 'IO::Socket::SSL <2.007 not supported by Net::NNTP';
 
 my $cert = 'certs/server-cert.pem';
 my $key = 'certs/server-key.pem';
diff --git a/t/nntpd.t b/t/nntpd.t
index 1c5ae8d7..fdb4bee4 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -104,6 +104,10 @@ EOF
 	SKIP: {
 		$n->can('starttls') or
 			skip('Net::NNTP too old to support STARTTLS', 2);
+		eval {
+			require IO::Socket::SSL;
+			IO::Socket::SSL->VERSION(2.007);
+		} or skip('IO::Socket::SSL <2.007 not supported by Net::NNTP');
 		ok(!$n->starttls, 'STARTTLS fails when unconfigured');
 		is($n->code, 580, 'got 580 code on server w/o TLS');
 	};
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01  9:07 [PATCH] t/nntpd*.t: require IO::Socket::SSL 2.007 for Net::NNTP tests Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox