From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/nntpd*.t: require IO::Socket::SSL 2.007 for Net::NNTP tests
Date: Mon, 1 Jul 2019 09:07:38 +0000 [thread overview]
Message-ID: <20190701090738.7468-1-e@80x24.org> (raw)
Net::NNTP won't attempt to use older versions of IO::Socket::SSL
because 2.007 is the "first version with default CA on most platforms"
according to comments in Net::NNTP. But then again we don't make
remote requests when testing...
---
t/nntpd-tls.t | 2 ++
t/nntpd.t | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index 4cf53daa..49b31221 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -13,6 +13,8 @@ foreach my $mod (qw(DBD::SQLite IO::Socket::SSL Net::NNTP IO::Poll)) {
}
Net::NNTP->can('starttls') or
plan skip_all => 'Net::NNTP does not support TLS';
+IO::Socket::SSL->VERSION(2.007) or
+ plan skip_all => 'IO::Socket::SSL <2.007 not supported by Net::NNTP';
my $cert = 'certs/server-cert.pem';
my $key = 'certs/server-key.pem';
diff --git a/t/nntpd.t b/t/nntpd.t
index 1c5ae8d7..fdb4bee4 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -104,6 +104,10 @@ EOF
SKIP: {
$n->can('starttls') or
skip('Net::NNTP too old to support STARTTLS', 2);
+ eval {
+ require IO::Socket::SSL;
+ IO::Socket::SSL->VERSION(2.007);
+ } or skip('IO::Socket::SSL <2.007 not supported by Net::NNTP');
ok(!$n->starttls, 'STARTTLS fails when unconfigured');
is($n->code, 580, 'got 580 code on server w/o TLS');
};
--
EW
reply other threads:[~2019-07-01 9:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701090738.7468-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).